File read/write problem

Dev Shed Forums Sponsor:

July 28th, 2006, 11:56 AM

mateoc15

Business Analyst

Join Date: Mar 2004

Location: The 'Ville

Posts: 1,087

Time spent in forums: 3 Days 19 h 17 m 11 sec
Reputation Power: 21

File read/write problem

This is MFC code, but the core of it is just ifstream and ofstream. The file pattern I'm looking for in this test is c:\temp1\test*.txt and the CFileFind successfully finds each file. I get to the part that checks for both files to be open and they both are. The first iteration through I get test1.txt and it opens the file, reads it, and writes it to the output file, no problems. But when I get to the second and third files test2.txt and test3.txt it opens the files, both are open, but it never writes anything to the output file.

Basically it never enters the while loop for files 2 and 3. All three files contain multiple lines and carriage returns. Any ideas?

Thanks in advance!

Code:

bWorking = find.FindFile(csInputFile);
		while(bWorking)
		{
			bWorking = find.FindNextFile();
			
			if(csInputFile.CompareNoCase(csOutputFile) == 0 || bWildcard)
			{
				csTemp = find.GetFilePath() + _T(".bak");
				rename((LPCTSTR) find.GetFilePath(), (LPCTSTR) csTemp);
			}	
			else
			{
				csTemp = csInputFile;
			}

			// skip directories ('.' and '..')
			if(!find.IsDots())
			{
				if(bWildcard)
				{
					csOutputFile = find.GetFilePath();
				}
				else
				{
					csOutputFile = csTemp;
					csOutputFile.TrimRight(_T(".bak"));
				}

				fInput.open((LPCTSTR)csTemp, ios::in);
				fOutput.open((LPCTSTR)csOutputFile, ios::out);			

// this part works, both are open	
if(fInput.is_open() != 0 &&
				   fOutput.is_open() != 0)
				{
					while(getline(fInput, s))
					{
						fOutput.write(s.c_str(), s.length());
					}

					// clean up
					fInput.close();
					fOutput.close();
				}
				else
				{
					bReturn = false;
				}
			}
		}

__________________
Discontent is the first necessity of progress. - Edison

Last edited by mateoc15 : July 28th, 2006 at 12:06 PM.

July 28th, 2006, 09:44 PM

Dave Sinkula

Contributing User

Dev Shed Intermediate (1500 - 1999 posts)

Join Date: Apr 2004

Posts: 1,676

Time spent in forums: 1 Month 3 Days 8 h 23 m 46 sec
Reputation Power: 132

[jogs memory]Instead of merely closing the streams, I think you also need to clear the flags -- namely that you are still at the end of the input file. Perhaps this will jog some else's memory while I search a bit...

[edit]This is something like what I was remembering.

Perhaps add an output statement where the is_open call fails to verify first.

__________________
Any advertisement triggered by IntelliTxt in this post is not endorsed by the author of this post.

Last edited by Dave Sinkula : July 28th, 2006 at 09:55 PM.

July 31st, 2006, 02:33 PM

mateoc15

Business Analyst

Join Date: Mar 2004

Location: The 'Ville

Posts: 1,087

Time spent in forums: 3 Days 19 h 17 m 11 sec
Reputation Power: 21

Quote:

Originally Posted by Dave Sinkula

I did a clear() to both files before closing them and solved the problem. Thanks!

File read/write problem

Developer Shed Advertisers and Affiliates