Three arrays but only one gets populated

Hi all,

I have a database table that has three records. Each record has date fields that help me create a record that equals one week.

I have a query that pulls the data from the table and puts it into a query object. Here's the query:

*************************
<cfquery name="qSessionClosures" datasource="#dataSource#">
SELECT
wksClosed.Afld_weeksClosed_ID, wksClosed.DTfld_weeksClosed_startDate, wksClosed.DTfld_weeksClosed_endDate, wksClosed.Nfld_weekClosed_listPosition, wksClosed.YNfld_weeksClosed_isActive, sessDate.Nfld_sessionDate_sessionNumber, sessDate.YNfld_sessionDate_isActive

FROM
tbl_cwt_weeksClosed AS wksClosed, tbl_cwt_sessionDate AS sessDate

WHERE
wksClosed.YNfld_weeksClosed_isActive = 1 AND sessDate.YNfld_sessionDate_isActive = 1

ORDER BY
wksClosed.DTfld_weeksClosed_startDate ASC
</cfquery>
****************************

I need to populate three arrays, one for each week so they can be used in all kinds of different ways. I'm trying to use "Nfld_weekClosed_listPosition" to uniquely identify each record and populate the corresponding array based on the list position number (which is 1,2 or 3).

Here's what my code looks like:

****************************
<cfset sessionNumber = #qSessionClosures.Nfld_sessionDate_sessionNumber#>

<!--- Test to see if each list position is being retrieved. --->
<cfloop query="qSessionClosures">
List Position:<cfoutput>#Nfld_weekClosed_listPosition# </cfoutput>
</cfloop>
<!--- END test for data retrieval. --->

<!--- BEGIN to populate the arrays. --->
<cfif listPosition EQ 1>
<cfset firstWeekClosed = ArrayNew(1)>
<cfset firstWeekClosed[1][1]= #qSessionClosures.DTfld_weeksClosed_startDate#>
<cfset firstWeekClosed[1][2]= #qSessionClosures.DTfld_weeksClosed_endDate#>
<cfset firstWeekClosed[1][3]= #qSessionClosures.Nfld_weekClosed_listPosition#>
</cfif>

<cfif listPosition EQ 2>
<cfset secondWeekClosed = ArrayNew(1)>
<cfset secondWeekClosed[1][1]= #qSessionClosures.DTfld_weeksClosed_startDate#>
<cfset secondWeekClosed[1][2]= #qSessionClosures.wksClosed.DTfld_weeksClosed_endDate#>
<cfset secondWeekClosed[1][3]= #qSessionClosures.Nfld_weekClosed_listPosition#>
</cfif>

<cfif listPosition EQ 3>
<cfset thirdWeekClosed = ArrayNew(1)>
<cfset thirdWeekClosed[1][1]= #qSessionClosures.DTfld_weeksClosed_startDate#>
<cfset thirdWeekClosed[1][2]= #qSessionClosures.wksClosed.DTfld_weeksClosed_endDate#>
<cfset thirdWeekClosed[1][3]= #qSessionClosures.Nfld_weekClosed_listPosition#>
</cfif>
<!--- END population of arrays. --->
****************************

With this code ONLY the first array gets populated. The subsequent arrays do not even exist. Please shed some light on this for me. It's probably a really simple solution but I'm just too close tot he problem to see it.

Thanks for any help.

Nathan

I don't see anywhere in your code where you're looping your query. For that, you can use either <cfloop query= or <cfoutput query=
Also, I don't see where you're incrementing the listPosition variable, which seems to be your counter variable.
The first would explain why only one array is being populated though.

Thank you for your reply!

I actually do have a bit of code that loops:

<!--- Test to see if each list position is being retrieved. --->
<cfloop query="qSessionClosures">
List Position:<cfoutput>#Nfld_weekClosed_listPosition# </cfoutput>
</cfloop>
<!--- END test for data retrieval. --->

I just don't know how to use this to populate the arrays.

I like your suggestion to increment the list position variable. I don't know how to do that as my brain is pretty muddled right now. Can you give me a code snippet that might work?


Nathan

You have a loop, but it's not over where you're setting the arrays. If you just call to access the recordset without moving to the next record, it will just give you the first record.

Also, you should remove those hash marks in your cfset statements because they're not necessary.
You also need to change your ArrayNew declarations to ArrayNew(2) since you're using two-dimensional arrays.

Everything bocmaxima said is spot on. There's several problems in your code but the big ones are not looping over the array set (which is why only the first array is being set), and the fact that you're building a 2D array but only creating a 1D array.

Finally, this is what I see: duplicate code. This should always be a red flag. You can do this in a much more concise way. Also, it doesn't look to me like you really want a 2 dimensional array at all, what you really want is an array of structures:

Thank you for your replies!

You've both made me a better CF developer and I'm grateful.
I'll implement those suggestions and I have no doubt they'll work.

Queation: Will I still be able to access one array seperate from the others? I may just want information on the first week and the third week at some point.

This was my reasoning in building three seperate arrays though I like the concise nature of your code snippet.

Nathan

Yes, you don't need three separate arrays, you'll have one array with 3 elements in it. So if you wanted to get the third element in the array and output it's start date, you'd do this:

#myArray[3].startDate#

You can always dump the whole variable to see it's contents as well:

<cfdump var="#myArray#">