Coments on my site

If any of you have time would you look at my site and tell me what you think, its a forum system, written towards my last year's degree work!

Join and post if you want.

Thanks

Not bad - search not working, getting ISE when click search button. Also, you need to validate the registration info when it is submitted. My username is 4 and my email is 4 - lol. I haven't tried posting anything but I am hopeing that your are validating the submitted data before entrering it into your DB - if not that is an extremely bad practice that can not go overlooked - your site can be hijacked real quick without validating user entered info....

I agree with jpenn. its looks pretty good from my end.

Cant check the backend, but taking what Jpenn said, I hope you have all the data well-arranged and well filtered.

none of the top buttons work in mozilla 1.0 on debian, you also need to think a bit more about security - code injection and most likely xss for everyone to enjoy. Not a good thing.
http://www.coolchip-computers.co.uk...=683&forumID=25

BTW, is it based on phpbb? And one more thing - quite a number of icons are most likely copyrighted by other boards, so you better check with them before you get a law suit.

I got my images from http://www.forumimages.com/index.html and i checked he said he was fine with me using his icons.

Yeh i saw your script. The reason you were aloud to do that was i've been testing for PHP code insertion, and for got to put remove html from a submitted post! oooppps.

The site isn't 100% completed yet and some features don't work! forgot to menion that, soz.

Yeh some more validation is needed when you register, and for usernames and stuff, i appreciate all, comments, criticsms., etc.... as it will help me get it working brilliant! Yeh its PHP based with MySql as the database, and Apapche as the web server on a windows 2000 box. Its not really based on any forum system as such, i'm borrowing ideas from most of the major ones tho.

I have Phoenix browser on my machine and the buttons work ok, but the cursor doesn't turn to a hand! If you click them they still work, any ideas why it doesn't work in Debian Mozilla? Its only a parent.location="index.php"

Let me know if theres anything else dudes!

Don't strip HTML, use htmlentities() or htmlspecialchars()

And all those damn jumping freaky faces on the Post page is freakin annoying... IMO



---John Holmes...

What do you mean by last year degree project?
Did you make this for your final project after 3-4 years of uni or just in the "previous" year.

Use cursor:pointer .

Btw,why the hell does your html code has a whole html page for each thread???You can only have one html element per page.

What you need for the buttons is to make them a link and then set the border to 0. Thats what is best for image buttons. Just set the link to read "javascript:;" or #

I'm in my 3rd year of a four year degree, i have started early in writing my final year project, I have decided i'm going to do a forum system, and this is my first attempt to get an idea on how to do it.

The Cool Chip Computers is just a company i've invented so i can host a current version on a server and hopefully get some members who will help test and sugest imporvements and features, etc.... RobUK is my mate and he's doing the same degree as me and wanted to help out, So all the coding is done by me, he just helps moderate and admin descions.

Anyway were still running, with over 2000 visitors and nearly a thousand post , take a look

Link in sig, will fix the mouse thing and the buttons as links

Well just keeping you inforemed.

Been playing with the graphics, what you think?

added a bit of flash to, any sugesstion etc... would be cool.

Looking good. Like the flash, very well done. Flash, if used well, can make a site look heaps better. Its when its used poorly that it screws up the look of the whole site.