#1
  1. A Change of Season
    Devshed Frequenter (2500 - 2999 posts)

    Join Date
    Mar 2004
    Location
    Next Door
    Posts
    2,653
    Rep Power
    171

    Is this good code?


    Hi;

    I had someone done this for me. Is it good quality code?

    Thanks
  2. #2
  3. Contributing User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Sep 2013
    Location
    Saint-Petersburg, Russia
    Posts
    236
    Rep Power
    28
    It depends on how much you have paid. And what you wanted at all. Looks like a simple template page. Not too bad. Nothing special. Looks like cross-browser and responsive to some extent.

    And by the way it is funny that you want audit of other's work to be performed without payment
    CodeAbbey - programming problems for novice coders
  4. #3
  5. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Aug 2013
    Location
    China
    Posts
    21
    Rep Power
    0
    Doesn't look too bad. Need to manage the text overflow in those bubble divs when you get down to mobile level, but that depends on what content you're going to put in them.

    The code looks pretty neat though.
  6. #4
  7. No Profile Picture
    Contributing User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Dec 2013
    Posts
    67
    Rep Power
    0
    The code itself is pretty solid. Very close to passing w3 html5 validation. I would fix up the 1 error I see and then you're golden.
  8. #5
  9. No Profile Picture
    Contributing User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Feb 2014
    Location
    India
    Posts
    73
    Rep Power
    1

    Thumbs up


    Well, it looks pretty good and the code is also finely done, you should add some more things, like flash content and other stuff.

    Code:
    <!--Start Wrap-->
     <div id="wrap" class="cf">
    	<!--Start Header-->
    	<header class="cf">
    	<a href="#" title="Logo" class="logo"></a>
    	        </header>
                    <!--End Header-->
    	        <!--Start Section Content-->
    	        <section class="content cf">
    		<div class="wrap_text">
    		<h1>Loreum ipsum dolor</h1>
    		Lorem Ipsum is simply dummy text of the printing 
    and typesetting industry. Lorem Ipsum has been the industry's
     standard dummy text ever since the 1500s, when an unknown
     printer took a galley of type and scrambled it to make a type 
    specimen book. It has survived not only five centuries, but 
    also the leap into electronic typesetting, remaining essentially
     unchanged. It was popularised in the 1960s with the release
     of Letraset sheets containing Lorem Ipsum passages, and 
    more recently with desktop publishing software like Aldus
     PageMaker including versions of Lorem Ipsum.
    		</div><!--/wrap_text-->
    		<div class="services">
    		<div class="row">
    		<a href="#" title="Add a Deal" class="add-a-deal">
                    <img src="images/add-a-deal.png" alt=""></a>              
    	        <a href="#" title="Blank Image" class="blank-image">	        
                    <p>Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy tex</p>
          <img src="images/blank-image.png" alt="" />							                    
    </a>
  10. #6
  11. No Profile Picture
    Contributing User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Aug 2010
    Posts
    33
    Rep Power
    4
    The markup looks well formed. There are issues with responsivness and the alignment of the text input fields in firefox.

    On the other hand, the design is poor in my opinion.
  12. #7
  13. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    May 2014
    Posts
    15
    Rep Power
    0
    It is well but can not say too good.
  14. #8
  15. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Jun 2014
    Posts
    28
    Rep Power
    0
    Originally Posted by Promatics
    It is well but can not say too good.
    The code of hexman you taking about?

    It may be not good in your sense but i think worth something. And may be user that ask will like this sol.
  16. #9
  17. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Jun 2014
    Posts
    16
    Rep Power
    0
    Its is good but we can to say too good.

IMN logo majestic logo threadwatch logo seochat tools logo