Continue to Outer Loop Isn't Working

Dev Shed Forums Sponsor:

March 4th, 2013, 01:54 PM

CJL9324

Registered User

Join Date: Oct 2008

Posts: 4

Time spent in forums: 44 m 36 sec
Reputation Power: 0

Continue to Outer Loop Isn't Working

Hey everyone. So my homework is to run a lottery program with a winning list picked randomly that doesn't have duplicates. That's the part I'm having problems with. I'm trying to check for duplicates and re-run the assignment loop if there is a duplicate. But everything I've tried, including continuing to the outer loop which I thought should work, generally creates a permanent loop. Help would be appreciated. Code segment is below.

Code:

int [] winners = new int[5];
		int c=0;
		
		outer: while (c<5)
		{
			Die d1 = new Die(1, 10);
			int w= d1.roll();
			winners[c]=w;
			System.out.print(" "+winners[c]);
				
			for(int i=0;i<5;i++)
			{ 
				boolean dup = false;
				
				for(int z=0;z<5;z++)
				{
					if(winners[i] == winners[z])
				    {
						dup = true;
						if(dup == true)
					    {
					    	continue outer;
					    }
				    }
					
				}
			}
			
			c++;
		}

March 4th, 2013, 07:05 PM

NormR

Contributing User

Join Date: Aug 2010

Location: SW Missouri

Posts: 2,955

Time spent in forums: 1 Week 6 Days 2 h 53 m 34 sec
Reputation Power: 345

Quote:

creates a permanent loop

The loop control variables must change for the loop to exit. Make sure all the paths the execution takes will change the variables that control the looping, otherwise the loop will go forever.

Code:

                dup = true;
		if(dup == true)

The if test is useless, it will ALWAYS be true.

March 4th, 2013, 09:34 PM

CJL9324

Registered User

Join Date: Oct 2008

Posts: 4

Time spent in forums: 44 m 36 sec
Reputation Power: 0

It was because the loops were checking the same spot in the array twice, needed to add an & clause to not let the element holding variable be the same either.

Thanks.

Viewing: Dev Shed Forums > Programming Languages > Java Help > Continue to Outer Loop Isn't Working

« Previous Thread | Next Thread »

Developer Shed Advertisers and Affiliates

Thread Tools	Search this Thread
Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread:

Posting Rules
You may not post new threads You may not post replies You may not post attachments You may not edit your posts vB code is On Smilies are On [IMG] code is On HTML code is Off

View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox

Forum Jump