Just find max & min in 8086

;please help me why this program not work?

dseg segment
;-------------------------------
n equ 4
arr dw 6,5,7,1
min dw ?
max dw ?
;-------------------------------
dseg ends

sseg segment stack
dw 100h dup(?)
sseg ends

cseg segment
assume ds:dseg,cs:cseg,ss:sseg
start: mov ax,dseg
mov ds,ax
;------------------------------
mov si,0
mov cl,n
mov max,0
mov min,0
l1: mov ax,arr[si]
cmp ax,max
ja big
jb small
big: mov max,ax
inc si
dec cl
jnz l1
small: cmp ax,min
jbe l2
l2: mov min,ax
inc si
dec cl
jnz l1
;------------------------------
sof: mov ah,4ch
int 21h
cseg ends
end start

You do not handle the min test properly.

On the line after the small lable you conditionally jump to lable l2 which is the next line in the program.

This question may be in the wrong category.

To find the minimum start big. 0 isn't big.

mov min,0

Thread moved to Other Programming Languages.

You probably want to set this to min and max 16-bit values (e.g.)


The logic here is flawed:

Since l2 is directly below the jbe line, the code will execute whether ax is smaller than min or not. You need to put another jmp instruction after jbe l2 to handle the case where ax >= min.