Perl Programming
 
Forums: » Register « |  User CP |  Games |  Calendar |  Members |  FAQs |  Sitemap |  Support | 
User Name:
Password:
Remember me
Go Back   Dev Shed ForumsProgramming LanguagesPerl Programming

Reply
Add This Thread To:
  Del.icio.us   Digg   Google   Spurl   Blink   Furl   Simpy   Y! MyWeb 
Thread Tools Search this Thread Rate Thread Display Modes
 
Unread Dev Shed Forums Sponsor:
Stop making mediocre tutorials.The best tutorials are video! Camtasia Studio makes it easy to create engaging, buzz-building screen videos at any size, in any popular format. Download the free trial!
  #1  
Old May 2nd, 2008, 10:34 PM
hychan hychan is offline
Registered User
Dev Shed Newbie (0 - 499 posts)
 
Join Date: May 2008
Posts: 3 hychan User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: 50 m 39 sec
Reputation Power: 0
Consolidating many CSV files into one

My following code supposed to read the many text files from my C drive and create a new text file, containing all the text files read. But my code seems to stop reading at "while (<INFILE>)". What is the problem?? I am using ActivePerl 5.10.0

$counter = 1;
$countArray = 0;
$monthfolder = "Mar08";
$lastdayofmonth = 31;

$newArray = 0;
$dir = "C:/WLBX/";
opendir(BIN, $dir) or die "Can't open $dir: $!";

while( defined ($scanDirectory = readdir BIN) ) {
unless (($scanDirectory eq ".") || ($scanDirectory eq "..")) {
if (-d $scanDirectory) {
$directoryArray[$newArray] = "$scanDirectory";
$newArray++;
}

}
}

closedir(BIN);


while ($countArray < $newArray) {

unlink ("C:/WLBX/$directoryArray[$countArray]/$monthfolder/$monthfolder.csv");

while ($counter <= $lastdayofmonth)
{
$file = "C:/WLBX/$directoryArray[$countArray]/$monthfolder/Daily/$counter.CSV";
print "\n$file";

$fname = "C:/WLBX/$directoryArray[$countArray]/$monthfolder/";
$fname .= "$monthfolder.csv";


open (FILE,">>$fname") or die "Couldn't create file $fname";


open(INFILE, $file);


# request an exclusive lock on the file.
flock(INFILE, LOCK_EX);
# read in each line from the file
while (<INFILE>)
{

######### it does not run this loop ########

# $_ is the line that <INFILE> has set.
#print "$_";

if ($counter == 1)
{
next unless $. > 2;
} else {
next unless $. > $newline;
}

print "$.";
print FILE $_;

} # close of while lockbox.txt creation
$endline = $.;
$newline = $endline + 2;
$counter = $counter +1;

} # close of while counter

flock(INFILE, LOCK_UN);
close(INFILE);
close(FILE);

$countArray++;
}

Reply With Quote
  #2  
Old May 3rd, 2008, 07:03 AM
Axweildr's Avatar
Axweildr Axweildr is offline
CPAN medic ...
Click here for more information.
 
Join Date: Mar 2003
Location: Location: Location:
Posts: 10,905 Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)  Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1
Time spent in forums: 3 Months 3 Weeks 6 Days 3 h 56 m 58 sec
Reputation Power: 2304
Send a message via Google Talk to Axweildr
Orkut
please post your code in [code ][ /code] tags without spaces
Code:
		open(INFILE, $file) or die $!;
		# request an exclusive lock on the file.
		flock(INFILE, LOCK_EX);  # I'm not 100%, but I don't think flock works on windows
		# read in each line from the file
		while (<INFILE>) {
			print "$."; #moved this line above the conditional
			if ($counter == 1) {
				next unless $. > 2;
			} else {
				next unless $. > $newline; #shouldn't this be initialised before the loop
			}
			print "$.";
			print FILE $_;

		} # close of while lockbox.txt creation
		$endline = $.;
		$newline = $endline + 2;
		$counter = $counter +1;

	} # close of while counter
	flock(INFILE, LOCK_UN);
	close(INFILE);
	close(FILE);
	$countArray++;
}
__________________
--Ax
without exception, there is no rule ...
The great thing about Object Oriented code is that it can make small, simple problems look like large, complex ones


09 F9 11 02
9D 74 E3 5B
D8 41 56 C5
63 56 88 C0
Some people, when confronted with a problem, think "I know, I'll use regular expressions." Now they have two problems.
-- Jamie Zawinski

Reply With Quote
  #3  
Old May 4th, 2008, 03:18 AM
hychan hychan is offline
Registered User
Dev Shed Newbie (0 - 499 posts)
 
Join Date: May 2008
Posts: 3 hychan User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: 50 m 39 sec
Reputation Power: 0
It still doesn't print "$." after I moved it before the "if ($counter == 1)"

As for the $newline, the first loop is always $counter == 1, therefore it should take "next unless $. > 2;", and when it comes to the 2nd loop, $newline already has a value assigned at the end of the while loop "$newline = $endline + 2;", therefore, I do not see the need to initialize the $newline at the beginning. Even if I intialized it, the problem still persists.

Reply With Quote
  #4  
Old May 4th, 2008, 03:45 AM
hychan hychan is offline
Registered User
Dev Shed Newbie (0 - 499 posts)
 
Join Date: May 2008
Posts: 3 hychan User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: 50 m 39 sec
Reputation Power: 0
hi Axweildr, I have just figured out what's wrong, I put the wrong path assigned to $file. The rest of the code is actually working Thank you very much for trying to help

Reply With Quote
  #5  
Old May 4th, 2008, 04:20 AM
Axweildr's Avatar
Axweildr Axweildr is offline
CPAN medic ...
Click here for more information.
 
Join Date: Mar 2003
Location: Location: Location:
Posts: 10,905 Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)Axweildr User rank is General 20th Grade (Above 100000 Reputation Level)  Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1Folding Points: 119844 Folding Title: Super Ultimate Folder - Level 1
Time spent in forums: 3 Months 3 Weeks 6 Days 3 h 56 m 58 sec
Reputation Power: 2304
Send a message via Google Talk to Axweildr
Orkut
that'd be the bit in red I take it?
Comments on this post
keath agrees!

Reply With Quote
Reply

Viewing: Dev Shed ForumsProgramming LanguagesPerl Programming > Consolidating many CSV files into one


Thread Tools  Search this Thread 
Search this Thread:

Advanced Search
Display Modes  Rate This Thread 
Rate This Thread:


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox
Forum Jump

 Free IT White Papers!
 
Accelerating Trading Partner Performance
One in five. That's how many partner transactions have at least one error. That is an amazing statistic, particularly given the extraordinary leaps in innovation across the global supply chain during the past two decades. Download this white paper to learn more.

 
Competing on Analytics
This Tech Analysis is designed to help identify characteristics shared by analytics competitors, and includes information about 32 organizations that have made a commitment to quantitative, fact-based analysis.

 
Cost Effective Scaling with Virtualization and Coyote Point Systems
An overview of the industry trend toward virtualization, how server consolidation has increased the importance of application uptime and the steps being taken to integrate load balancing technology with virtualized servers.

 
Five Checkpoints to Implementing IP Telephony
Implementation planning for IP PBX software and IP telephony has become vital as businesses replace discontinued legacy PBX phone systems. This informative whitepaper outlines five "checkpoints" for any implementation plan that will help make IP communications a successful proposition.

 
Hosted Email Security: Staying Ahead of New Threats
In the last two years, email has become a fierce battleground between the nefarious forces of spam and malware, and the heroes of messaging protection. The spam volumes increased alarmingly every month, bringing clever new forms of phishing and virus propagation attacks.

 

Forums: » Register « |  User CP |  Games |  Calendar |  Members |  FAQs |  Sitemap |  Support | 
  
 





© 2003-2008 by Developer Shed. All rights reserved. DS Cluster 5 hosted by Hostway