List files in a directory into array and print

I would like to list all *.rpt files in a directory into an array and then convert each file name into a link. The $rpts parameter is sourced from an html page with three links: Billing, GL, Inventory. I have presented test code here for review. When you replace $rpts with, say, 'billing', one would expect a list of files to display but nothing happens -?! Any help would be greatly appreciated!


#!/usr/bin/perl

#use strict;
use CGI qw(:standard);

#Three types of web reports: Billing, GL, Inventory
#my $rpts = param('reports');

my $dir = "/production/reports/$rpts";

opendir(DIR, $dir);

while (my @file = readdir(DIR)) {

# We only want files
next unless (-f "$dir/@file");

# Use a regular expression to find files ending in .rpt
next unless (@file =~ m/\.rpt$/);

print "$file(@file)\n";
}

closedir(DIR);

exit 0;

Try it like this:

Code:

my $file_name_search  =  "dir_path/*.rpt";
my @file_names_found;

# Search for files and load array of qualified file names to zip.
@file_names_found  =  glob("$file_name_search");

# Print names of files found
if ( ! @file_names_found ) {
  print "No files were found.\n";
} else {
  foreach $fnf ( @file_names_found ) {
    print "$fnf\n";
  }
}

This would not compile if you had uses the "use strict;" and "use wartnings;" pragmas because the $repts variable is not defined.


also does not make much sense to me.

You could try this:

Rather than using 2 (or more) statements to get the file list, I'd use a single grep statement.