Always same result... Login failure

Dev Shed Forums Sponsor:

January 2nd, 2013, 11:52 AM

southwind84

Registered User

Join Date: Jan 2013

Posts: 1

Time spent in forums: 25 m 36 sec
Reputation Power: 0

Always same result... Login failure

Hope someone can help me....
First of all sorry for my bad english!
I'm trying to write an php code for a user login.
When I run the code i always get the same result:"Login failure".
Even if thes "user" and "password" that i tiped in exists or not.
I used xampp 3.1.0, databasename: login, tablename: login.
Think about it for days but can't find any solution, please can someone help me? what i do wrong?

Here is the code:

<html>
<head >
<body>

<form action='login.php?login=yes' method=POST>
Username:<input type=text name='user' /><br />
Password: <input type=password name='pass' /> <br />
<input type=submit value='Go!' />
</form>

<?php

$user=isset($_POST['user']);
$pass=isset($_POST['pass']);
$login=isset($_GET['login']);

if($login=='yes')
{
$con=mysql_connect('localhost','root','root') or die("Cant connect host");
mysql_select_db('login') or die("Cant connect database");

$get=mysql_query("SELECT count(id) FROM login WHERE (user='$user' AND pass='$pass')") or die ("Error on mysql_querry");
$result=mysql_result($get,0);

if($result!=1) echo "Login failure!";
else {
echo "Login sucess!";
$_SESSION['user']=$user;
}

}
?>

</head>
</body>
</html>

January 4th, 2013, 10:23 AM

Jyncka

We're trapped inside a game!

Join Date: Jul 2008

Location: Maryland

Posts: 299

Folding Points: 37258 Folding Title: Starter Folder

Time spent in forums: 5 Days 9 h 30 m 29 sec
Reputation Power: 902

You have some syntax problems in your code. Please use code tags to format it in your post so everyone can read it more easily.

The error I see is this

Quote:

user='$user' AND pass='$pass'

The single quotes tell PHP to interpret those variables as strings. You are querying for rows where user has a value of "$user" and password has a value of "$pass". Try removing the single quotes.

Finally, this seems like it should be moved to the PHP board since it's a coding error.

__________________
"Those who can make you believe absurdities can make you commit atrocities."

January 4th, 2013, 11:10 AM

r937

SQL Consultant

Dev Shed God 43rd Plane (26000 - 26499 posts)

Join Date: Feb 2003

Location: Toronto Canada

Posts: 26,443

Time spent in forums: 3 Months 1 Week 2 Days 14 h 22 m 31 sec
Reputation Power: 4141

Quote:

Originally Posted by Jyncka

The single quotes tell PHP to interpret those variables as strings.

actually, those single quotes are for mysql, not for php, but yes, they delimit strings

if you remove them, you will have an sql statement that says

Code:

WHERE (user=fred AND pass=sesame)

and at that point, mysql interprets fred and sesame as column names, resulting in an error

the only time the quotes are not required is when the columns are numeric and the values are numbers

__________________
r937.com | rudy.ca
please visit Simply SQL and buy my book

Always same result... Login failure

Developer Shed Advertisers and Affiliates