Login Function Stopped Working

Dev Shed Forums Sponsor:

January 4th, 2013, 03:26 PM

nbasso713

Contributing User

Join Date: Dec 2012

Posts: 64

Time spent in forums: 11 h 36 m 11 sec
Reputation Power: 1

Login Function Stopped Working

Everything worked great on wamp, but when I uploaded my files to a live server i'm getting the following error. I don't see where or how it should be expecting a second parameter.

Warning: mysql_result() expects parameter 1 to be resource, boolean given

PHP Code:


		
			
function login($username, $password){

    $user_id = user_id_from_username($username);

    

    $username = sanitize($username);

    $password = sanitize($password);

    

    return (mysql_result(mysql_query("SELECT COUNT(`ID`) FROM `members` WHERE `username` = '$username' AND `password` = pwdencrypt('$password')"))==1) ? $user_id : false;

}

January 4th, 2013, 03:42 PM

nbasso713

Contributing User

Join Date: Dec 2012

Posts: 64

Time spent in forums: 11 h 36 m 11 sec
Reputation Power: 1

SOLVED

PHP Code:


		
			
return (mysql_result(mysql_query("SELECT COUNT(`ID`) FROM `members` WHERE `username` = '$username' AND `password` = 'pwdencrypt($password)'"), 0)==1) ? $user_id : false;

January 4th, 2013, 03:43 PM

requinix

Still alive

Join Date: Mar 2007

Location: Washington, USA

Posts: 12,702

Folding Points: 417516 Folding Title: Super Ultimate Folder - Level 1

Time spent in forums: 5 Months 1 Week 4 Days 5 h 32 m 15 sec
Reputation Power: 8969

Send a message via Google Talk to requinix

Uh no, not solved. At least I hope not: you're comparing the password against the string "pwdencrypt(password)", not the actual hashed/encrypted password.

__________________
Site rules and FAQ | Project Suggestions | mod_rewrite guide | PHP New User Guide and FAQ - PHP Stickies | Regex Resources

January 4th, 2013, 03:46 PM

nbasso713

Contributing User

Join Date: Dec 2012

Posts: 64

Time spent in forums: 11 h 36 m 11 sec
Reputation Power: 1

Quote:

Originally Posted by requinix

Uh no, not solved. At least I hope not: you're comparing the password against the string "pwdencrypt(password)", not the actual hashed/encrypted password.

Crap you're right thanks for pointing this out, gotta try to fix this.

January 4th, 2013, 04:28 PM

requinix

Still alive

Join Date: Mar 2007

Location: Washington, USA

Posts: 12,702

Time spent in forums: 5 Months 1 Week 4 Days 5 h 32 m 15 sec
Reputation Power: 8969

You sure it's pwdencrypt() and not, say, ENCRYPT or PASSWORD?

January 4th, 2013, 04:38 PM

nbasso713

Contributing User

Join Date: Dec 2012

Posts: 64

Time spent in forums: 11 h 36 m 11 sec
Reputation Power: 1

Quote:

Originally Posted by requinix

You sure it's pwdencrypt() and not, say, ENCRYPT or PASSWORD?

pwdencrypt worked on wamp, and it did compare the password to the encrypted password at the time.

The problem I'm having now is that mysql_result is expecting two parameters. The "0" in:

PHP Code:


		
			
 pwdencrypt('$password')"), 0)==1)

Seems to bypass the need for a password altogether. As long as a registered username is entered the user is logged in.

No "0" produces the error:
Warning: mysql_result() expects at least 2 parameters, 1 given

So far any other values I have tried have also produced errors. Any help would be appreciated this is pretty frustrating. I did test this without using an encrypted password an I'm still having the same issue.

January 4th, 2013, 05:29 PM

nbasso713

Contributing User

Join Date: Dec 2012

Posts: 64

Time spent in forums: 11 h 36 m 11 sec
Reputation Power: 1

All good now

PHP Code:


		
			
return (mysql_result(mysql_query("SELECT `username` FROM `members` WHERE `username` = '$username' AND `password` = password('$password')"),0)==1) ? $user_id : false;