#1
  1. Banned ;)
    Devshed Supreme Being (6500+ posts)

    Join Date
    Nov 2001
    Location
    Woodland Hills, Los Angeles County, California, USA
    Posts
    9,648
    Rep Power
    4248

    Feedback wanted for my python code


    This is a program I wrote to add copyright notices and licenses to my source code files automatically. As a matter of fact, I used the program to add BSD-style licenses to its own source code! .

    Here it is:
    http://www.mayukhbose.com/python/addlice/index.php

    Please take a look and let me know what you think.
    Up the Irons
    What Would Jimi Do? Smash amps. Burn guitar. Take the groupies home.
    "Death Before Dishonour, my Friends!!" - Bruce D ickinson, Iron Maiden Aug 20, 2005 @ OzzFest
    Down with Sharon Osbourne

    "I wouldn't hire a butcher to fix my car. I also wouldn't hire a marketing firm to build my website." - Nilpo
  2. #2
  3. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Aug 2003
    Posts
    217
    Rep Power
    0
    I havn't had time to look at the source yet, but it is sure going to be useful for me .

    Keep it up!
  4. #3
  5. Hello World :)
    Devshed Frequenter (2500 - 2999 posts)

    Join Date
    Mar 2003
    Location
    Hull, UK
    Posts
    2,537
    Rep Power
    69
    It's a great idea and bound to be useful to a whole bunch of people . Anyway i've only skimmed through it (2:45am), first impressions arn't bad although it seems to be a little over complicated in places IMO.

    The main improvment i think you could make to the program so far would be to have the licences in a seperate text file instead of in 'licenseobjects'.

    I do like the way the file type (extention) is used to deside what to do though, a nice touch!

    But other than that its a good little program, obviously there are some places that could be done differently but nothing major .

    Keep up the good work,

    Mark.
    programming language development: www.netytan.com Hula

  6. #4
  7. Mini me.
    Devshed Novice (500 - 999 posts)

    Join Date
    Nov 2003
    Location
    Cambridge, UK
    Posts
    783
    Rep Power
    14
    I like this utility, definitely something I can use to retrospectively update my files .

    A few suggestions:
    1. It could be useful to allow the replacement of one license with another (update of license or change in policy).
    2. I agree with Netytan on one point: The licenses should be external files. My preference is for a license directory, somewhere in the document path that can be edited easily by the user. The license files could be like something like gpl.lic gpl2.lic mit.lic, mylicense.lic.
    3. I would like to put the program in the pythonpath as a utility in that case it would be good to have a distutils setup.py file to install it.
    4. And to avoid filename clutter - in its own package directory or reduce it to one module only.

    Cheers,
    Grim
  8. #5
  9. Banned ;)
    Devshed Supreme Being (6500+ posts)

    Join Date
    Nov 2001
    Location
    Woodland Hills, Los Angeles County, California, USA
    Posts
    9,648
    Rep Power
    4248
    Thanks for the feedback guys. Will implement changes later in the week .
    Up the Irons
    What Would Jimi Do? Smash amps. Burn guitar. Take the groupies home.
    "Death Before Dishonour, my Friends!!" - Bruce D ickinson, Iron Maiden Aug 20, 2005 @ OzzFest
    Down with Sharon Osbourne

    "I wouldn't hire a butcher to fix my car. I also wouldn't hire a marketing firm to build my website." - Nilpo
  10. #6
  11. No Profile Picture
    Contributing User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Dec 2001
    Location
    Houston, TX
    Posts
    383
    Rep Power
    14
    Nifty idea, but I have one comment. I haven't looked at the code (yet), but while tihs program is nifty (like I said ), I can't think of why many would use it simply because most people pick their favorite license to release things under and then stick with that. If they do that, then the easiest way to insert this license into your source code header is to simply set up a template that your editor will read into the buffer every time you start a new file with that given extension.

    Just my two cents.
    Debian - because life's too short for worrying.
    Best. (Python.) IRC bot. ever.

IMN logo majestic logo threadwatch logo seochat tools logo