Need help with preg_replace

Dev Shed Forums Sponsor:

June 16th, 2009, 06:25 PM

ignas2526

Registered User

Join Date: Jun 2009

Posts: 6

Time spent in forums: 1 h 35 m
Reputation Power: 0

Need help with preg_replace

Hello,
I trying to add checked="checked" to the input which value x.
find '<input'.anything here.'value="'.value.'"'.anything
replace '<input' with <input checked="checked"

here is what I end up with:

Code:

//text in which preg_replace must find input
$v = 'some text<input name="something1" type="checkbox" value="123" />something here<br><br><input name="something2" type="checkbox" value="122" /><br>';
$output = preg_replace('/<input(.*?value="123" .*?)\s/','<input checked="checked"$1',$v,1);
echo $output

result:
some text<input checked="checked" name="something1" type="checkbox" value="123" />somethinghere<br><br><input name="something2" type="checkbox" value="122" /><br>
expected result:
some text<input checked="checked" name="something1" type="checkbox" value="123" />something here<br><br><input name="something2" type="checkbox" value="122" /><br>

Any ideas how to fix that?
Thanks.

June 16th, 2009, 06:37 PM

OmegaZero

Contributing User

Join Date: May 2007

Posts: 737

Time spent in forums: 3 Weeks 4 Days 22 h 50 m 16 sec
Reputation Power: 928

You're problem is the regex has a \s on the end that isn't included in the capture, so it is removed from the string and not replaced.

A better solution is not to match more than you care about. The look ahead makes sure that value="123" appears, but doesn't include it in the match.

Code:

/<input(?=.*value="123")/

The best solution would be to parse the markup and make your changes to the tree structure. The regex will get confused with input like:

Code:

<input/> value="123"
<input value="wrong"/> <input value="123"/>

__________________
sub{*{$::{$_}}{CODE}==$_[0]&& print for(%:: )}->(\&Meh);

June 16th, 2009, 07:28 PM

ignas2526

Registered User

Join Date: Jun 2009

Posts: 6

Time spent in forums: 1 h 35 m
Reputation Power: 0

Thank you for quick reply, well the value will be only filled with inputs so markup will be clean, however speed is important, i just found what
preg_replace('|value="'.$i.'"|','value="'.$i.'" checked="checked"',$v,1);
is three times quicker than
preg_replace('/<input(?=.*value="123")/','<input checked="checked"$1',$v,1);

Viewing: Dev Shed Forums > Programming Languages - More > Regex Programming > Need help with preg_replace

« Previous Thread | Next Thread »

Developer Shed Advertisers and Affiliates

Thread Tools	Search this Thread
Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread:

Posting Rules
You may not post new threads You may not post replies You may not post attachments You may not edit your posts vB code is On Smilies are On [IMG] code is On HTML code is Off

View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox

Forum Jump