Thread: Algorithm help.

    #1
  1. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Oct 2012
    Posts
    2
    Rep Power
    0

    Algorithm help.


    Let say I have an array with the following numbers:

    1,4,12,22,53,51,49,55,2,5,50,51,100


    I'm trying to develop an algorithm that finds the max number of consecutive number in the array that is between 40 and 60.

    For the example above, the algorithm should return 53,51,49 and 55. 50,51 are not returned because that is only 2 consective number that is between 40 and 60.
  2. #2
  3. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Nov 2012
    Posts
    14
    Rep Power
    0
    Hi huyvu90,

    Unless I'm misunderstanding, I think this should do what you want:

    Code:
    Dim ArNums() As Integer
    Dim i As Integer, j As Integer
    Dim savej As Integer
    
    '....code to load numbers into array ArNums
        
         For i = 0 To UBound(ArNums)
            If ArNums(i) > 40 And ArNums(i) < 60 Then
                j = j + 1
                If j > savej Then
                    savej = j
                End If
            Else
                j = 0
            End If
        Next i
    
        MsgBox savej          '<----- this should be your answer
                                    ' ('4' for your example)
    cheers,

    argee
  4. #3
  5. No Profile Picture
    Contributing User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Nov 2010
    Posts
    119
    Rep Power
    158
    Originally Posted by argee
    Hi huyvu90,

    Unless I'm misunderstanding, I think this should do what you want:

    Code:
    Dim ArNums() As Integer
    Dim i As Integer, j As Integer
    Dim savej As Integer
    
    '....code to load numbers into array ArNums
        
         For i = 0 To UBound(ArNums)
            If ArNums(i) > 40 And ArNums(i) < 60 Then
                j = j + 1
                If j > savej Then
                    savej = j
                End If
            Else
                j = 0
            End If
        Next i
    
        MsgBox savej          '<----- this should be your answer
                                    ' ('4' for your example)
    cheers,

    argee
    you missed the point!

    you have coded for an algorythm that returns the number of 40 to 60 values and not considered the consecutive part of the question

    the looping is fine but you need to be looking ahead and you need to be flagging the count-now nature of the problem

    try walking through the array with 2 pointers if and only if they both point to values in the range should you show them and remember to indicate that a match has ben found. Using the match you will be able to deduce that the first pointer is pointing at a valid entry when the pointers no longer have values in range and at that point you should reset the flag and output the first pointed to value.

    hope that explains what to do

    code available if needed
  6. #4
  7. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Nov 2012
    Posts
    14
    Rep Power
    0
    I am allowing for the consecutive part of the problem.

    That's why the loop resets the value of j to 0 if a match is not found, because then the matches are no longer consecutive.

    The number of consecutive matches is stored in "savej" only if it exceeds any previously stored value in "savej".

    I had considered afterwards that, although they initially said they wanted the maximum number of values, the OP may have wanted the actual consecutive number group returned, not just the count of them. The code could be modified like this :

    Code:
    Dim intStartPos As Integer
    Dim strResult As String
    
    '...code to load numbers into array ArNums
        
        For i = 0 To UBound(ArNums)
            If ArNums(i) > 40 And ArNums(i) < 60 Then
                j = j + 1
                If j > savej Then
                    savej = j
                    intStartPos = i - j
                End If
            Else
                j = 0
            End If
        Next i
    
        For i = (intStartPos + 1) To (intStartPos + savej)
            strResult = strResult & ArNums(i) & ","
        Next i
    
        Debug.Print strResult       'contains the consecutive matches separated by commas
    In any case, this thread is aging and the original poster has not returned it seems.
  8. #5
  9. No Profile Picture
    Contributing User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Nov 2010
    Posts
    119
    Rep Power
    158

    nicely done


    I didnt complete my writeup, but its nice to see you did - well done, and the explaination will help others understand your process better.
  10. #6
  11. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Feb 2013
    Posts
    18
    Rep Power
    0

    algorythm


    the main power of VBA is to use it with excel to do the serious number crunching

    Your problem is quite hard in vba but very easy in excel

    use VBA to load input and extract and display answers and excel to crunch the numbers

    i can't attach for some reason but i have written a spreadsheet to crack it in about 2 mins

    email me at graham.griggs@tiscali.co.uk and i will send you a copy

IMN logo majestic logo threadwatch logo seochat tools logo