Css help/testing - Dev Shed

Dev Shed Forums Sponsor:

April 24th, 2009, 11:16 PM

KP77

Registered User

Join Date: Apr 2009

Location: ohio

Posts: 3

Time spent in forums: 54 m 14 sec
Reputation Power: 0

Css help/testing

Quote:

#body {

margin:auto;

background:#fcfff0;

color:rgb(16%, 14%, 13%);

text-align:center;

width:640px;

}

#outer {

text-align:center;

border:0px solid #325C74;

width:640px;

margin:auto;

}

#header {

height:100px;

background:#fcfff0;

color:rgb(16%, 14%, 13%);

}

#bar {

height:25px;

background:#fcfff0;

color: rgb(16%, 14%, 13%);

border:6px solid #325C74;

text-align:center;

}

#cont{

height:380px;

width:628px;

background:#fcfff0;

color:rgb(16%, 14%, 13%);

border:6px solid #325C74;

margin:auto;

text-align:center;

}

#left {

float: left;
height:380px;

width:200px;

background:#fcfff0;

color:rgb(16%, 14%, 13%);

border:0px solid #325C74;

text-align:center;

}

#right {

float: right;
height:380px;

width:200px;

background:#fcfff0;

color:rgb(16%, 14%, 13%);

border:0px solid #325C74;

text-align:center;

}

#footer {

height:40px;

width:628px;

background:#fcfff0;

color:rgb(55%, 9%, 9%);

border:6px solid #325C74;

margin:auto;

text-align:center;

}

my question is there anything I need to do to make it better
I'm still learning css
I have tested it at w3 and its passed at all levels but I get 7 warning at css3

April 25th, 2009, 05:24 PM

Skipt

CSS Guru in Training

Join Date: Jan 2009

Location: Maryland, USA

Posts: 2,044

Folding Points: 84 Folding Title: Novice Folder

Time spent in forums: 3 Weeks 1 Day 1 h 59 m 48 sec
Reputation Power: 1225

There's nothing wrong with the code, except on #footer, add clear:both;. I also don't recommend having a fixed height, or width. I much prefer min-width, max-width, and using %'s. Without a link, there's not much else I can say

__________________
"Quality of responses may vary. I reserve the right to change my mind for any reason what-so-ever without admitting I was wrong. I'd prefer to change your mind however, it's easier on my ego". - jwdonahue

April 25th, 2009, 06:29 PM

holodoc

Contributing User

Join Date: Mar 2004

Location: Kostolac, Serbia

Posts: 663

Time spent in forums: 2 Weeks 1 Day 15 h 35 m 6 sec
Reputation Power: 980

Send a message via Google Talk to holodoc

There are two things I would like to comment on your CSS.

First of all you don't need to specify additional values for your selector's properties if one of them is going to completely cancel the effect of even showing it. Look at the following selector:

Code:

border:0px solid #325C74;

By specifying a value of 0px (xp is btw redundant here) for border width you do not need to specify the border type (solid) and border color (#325C74). This might seem unimportant to some but when you begin to create large CSS files with lots of selectors which contain redundant values you will get files with lot of unnecessary junk in it.

Also there is nothing wrong with using percentage values in your RGB color specifications but to be honest I never even came close to a CSS rule that was using repcentages to define color values and not be actually a part of a tutorial which was simply explaining that percents can be used to specify color values. Most of the time you will be using hexadecimal values so it might be a good idea for you to start learning the hex system in a way to at least have a feeling which color will be produced with a certain hexadecimal color value combination.

As for the warnings you get ignore them. The W3 CSS validator is not so perfect after all since it gives you warnings for things that do not exist in your code.

__________________

PHP Code:


		
			
<?php 

abstract class Ignorance extends Stupidity implements Unavoidable { 

     public static $humiliation; 



     final function findCover(); 

} 

?>

Last edited by holodoc : April 25th, 2009 at 06:38 PM.

April 25th, 2009, 08:23 PM

KP77

Registered User

Join Date: Apr 2009

Location: ohio

Posts: 3

Time spent in forums: 54 m 14 sec
Reputation Power: 0

thanks for your advice guys
you could check my profile for the link to my website since i can't post a links yet

April 26th, 2009, 11:30 AM

Skipt

CSS Guru in Training

Join Date: Jan 2009

Location: Maryland, USA

Posts: 2,044

Time spent in forums: 3 Weeks 1 Day 1 h 59 m 48 sec
Reputation Power: 1225

So now you want a site critique? Hopefully a moderator could move the thread.

For those of you who don't want to open up his profile. The link is here:

http://www.angelfire.com/games3/twrt/

1. I don't like the width of the site. I don't want to scroll horizontally to reach content. Nor do most users.
2. Below the ad, that box I thinik should be centered between the top row instead of the center of the screen, unless you choose to center the ads and make them smaller
3. Style up the navbar a bit. It really is quite plain
4. "This site is best viewed in Firefox or Safari ". Try making your site work in all browsers

Comments on this post

ChiefWigs1982 disagrees: This could be one of the most hypocritical posts I've ever seen. :/

Viewing: Dev Shed Forums > Web Design > Website Critiques > Css help/testing

« Previous Thread | Next Thread »

Thread Tools	Search this Thread
Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread:

Posting Rules
You may not post new threads You may not post replies You may not post attachments You may not edit your posts vB code is On Smilies are On [IMG] code is On HTML code is Off

View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox

Forum Jump

Free IT White Papers!

How to Present Effectively Online
This white paper offers practical and actionable advice on the key steps that any presenter should consider as they plan and execute a Webinar or online meeting.

Open Source Security Myths
Open Source Software (OSS) is computer software whose source code is available to the general public with relaxed or non-existent intellectual property restrictions (or arrangement such as the public domain), and is usually developed with the input of many contributors.

Power and Cooling Capacity Management for Data Centers
This paper describes the principles for achieving power and cooling capacity management.

Scalable, Fault-Tolerant NAS for Oracle - The Next Generation
For several years NAS has been evolving as a storage alternative for Oracle databases, and for good reason: NAS is quite often the simplest, most cost-effective storage approach for Oracle. Learn about the benefits that HP's approach to scalable NAS brings to Oracle environments in this comprehensive white paper.

Understanding Web Application Security Challenges
This white paper discusses many common threats and preventive measures for Web application security, and explains what you can do to help protect your organization.

More Free IT White Papers!