Discuss Css help/testing in the Website Critiques forum on Dev Shed. Css help/testing Website Critiques forum discussing your website. Get recommendations on areas of improvement by design and development experts. Discover your site's weak spots. You must be a member for at least 30 days and have at least 30 posts to list your site.
Posts: 3
Time spent in forums: 54 m 14 sec
Reputation Power: 0
Css help/testing
Quote:
#body {
margin:auto;
background:#fcfff0;
color:rgb(16%, 14%, 13%);
text-align:center;
width:640px;
}
#outer {
text-align:center;
border:0px solid #325C74;
width:640px;
margin:auto;
}
#header {
height:100px;
background:#fcfff0;
color:rgb(16%, 14%, 13%);
}
#bar {
height:25px;
background:#fcfff0;
color: rgb(16%, 14%, 13%);
border:6px solid #325C74;
text-align:center;
}
#cont{
height:380px;
width:628px;
background:#fcfff0;
color:rgb(16%, 14%, 13%);
border:6px solid #325C74;
margin:auto;
text-align:center;
}
#left {
float: left;
height:380px;
width:200px;
background:#fcfff0;
color:rgb(16%, 14%, 13%);
border:0px solid #325C74;
text-align:center;
}
#right {
float: right;
height:380px;
width:200px;
background:#fcfff0;
color:rgb(16%, 14%, 13%);
border:0px solid #325C74;
text-align:center;
}
#footer {
height:40px;
width:628px;
background:#fcfff0;
color:rgb(55%, 9%, 9%);
border:6px solid #325C74;
margin:auto;
text-align:center;
}
my question is there anything I need to do to make it better
I'm still learning css
I have tested it at w3 and its passed at all levels but I get 7 warning at css3
Posts: 2,215
Time spent in forums: 3 Weeks 3 Days 6 h 32 m 28 sec
Reputation Power: 2178
There's nothing wrong with the code, except on #footer, add clear:both;. I also don't recommend having a fixed height, or width. I much prefer min-width, max-width, and using %'s. Without a link, there's not much else I can say
__________________
"Quality of responses may vary. I reserve the right to change my mind for any reason what-so-ever without admitting I was wrong. I'd prefer to change your mind however, it's easier on my ego". - jwdonahue
"so no-one has actually bothered to post an original quote ? what's wrong with making up your own?"
- marnixR
Posts: 855
Time spent in forums: 2 Weeks 5 Days 4 h 47 m 40 sec
Reputation Power: 1390
There are two things I would like to comment on your CSS.
First of all you don't need to specify additional values for your selector's properties if one of them is going to completely cancel the effect of even showing it. Look at the following selector:
Code:
border:0px solid #325C74;
By specifying a value of 0px (xp is btw redundant here) for border width you do not need to specify the border type (solid) and border color (#325C74). This might seem unimportant to some but when you begin to create large CSS files with lots of selectors which contain redundant values you will get files with lot of unnecessary junk in it.
Also there is nothing wrong with using percentage values in your RGB color specifications but to be honest I never even came close to a CSS rule that was using repcentages to define color values and not be actually a part of a tutorial which was simply explaining that percents can be used to specify color values. Most of the time you will be using hexadecimal values so it might be a good idea for you to start learning the hex system in a way to at least have a feeling which color will be produced with a certain hexadecimal color value combination.
As for the warnings you get ignore them. The W3 CSS validator is not so perfect after all since it gives you warnings for things that do not exist in your code.
__________________
PHP Code:
<?php
abstract class Ignorance extends Stupidity implements Unavoidable {
public static $humiliation;
private function __construct(){
parent::__destruct();
};
}
?>
Last edited by holodoc : April 25th, 2009 at 05:38 PM.
1. I don't like the width of the site. I don't want to scroll horizontally to reach content. Nor do most users.
2. Below the ad, that box I thinik should be centered between the top row instead of the center of the screen, unless you choose to center the ads and make them smaller
3. Style up the navbar a bit. It really is quite plain
4. "This site is best viewed in Firefox or Safari ". Try making your site work in all browsers
Del.icio.us
Digg
Google
Spurl
Blink
Furl
Simpy
Y! MyWeb
Css help/testing
Linear Mode
