http://www.lampdesign.co.uk/desdev/vsc/

Hi ya,

I am working on a site for a company that sell old advertising signs and would appreciate any feedback people might have before I commit myself to the design!

It is here:

http://www.lampdesign.co.uk/desdev/vsc/

Thanks!

404... Is that on purpose? Do you still want some input?

I get a 404.

Hi There,

My original post was submitted some time ago and the site has since been moved onto it's real url.

You can view the site here:

http://www.thevintagesigncompany.com/

Please note;

There are some empty pages and the index content is not all there. The empty parts need to be filled by the client via a CMS.

Thanks for taking a look!

Nice site, with a good, easy to navigate layout. Everything was pretty easy to read.

You've got some validation issues on your registration form, however. View my profile (name: asdf asdf) to see why. I can inject JavaScript and/or some HTML into your form. Low risk, but still worth fixing. Use htmlentities() on your data before you "redisplay" it in a form element.

---John Holmes...

Thanks for that advice about javascript/html injection.

I had made sure that my ecommerce system was safe from sql injection sometime ago and neglected to do this.

I have subsequently written a function to check all user input for js and html and remove/replace it. All current installs will be patched and I will be updating the codebase so that it is covered for the next version.

I didn't realise that you had been on there until I checked the database this evening and noticed that somebody had attemtpted something! I was quite alarmed and set about preventing it immediately!

I backtracked and realised that this was the only place I had publised the URL and was hoping that it was somebody checking the site out.

Thanks very much for your post - much appreciated.

Heh.. yeah, that was me. Hope I didn't mess anything up. Good luck with the security.

---John Holmes...