Website Critiques
 
Forums: » Register « |  User CP |  Games |  Calendar |  Members |  FAQs |  Sitemap |  Support | 
User Name:
Password:
Remember me
Go Back   Dev Shed Forums > Web Design > Website Critiques
Reload this Page

Improve my code, have i missed out any errors?

Discuss Improve my code, have i missed out any errors? in the Website Critiques forum on Dev Shed.
Improve my code, have i missed out any errors? Website Critiques forum discussing your website. Get recommendations on areas of improvement by design and development experts. Discover your site's weak spots. You must be a member for at least 30 days and have at least 30 posts to list your site.

Reply
Add This Thread To:
  Del.icio.us   Digg   Google   Spurl   Blink   Furl   Simpy   Y! MyWeb 
« Previous Thread | Next Thread »  
Thread Tools Search this Thread Rate Thread Display Modes
 
Unread Dev Shed Forums Sponsor:
  #1  
Old April 29th, 2004, 09:43 AM
killmesuicide killmesuicide is offline
Registered User
Dev Shed Newbie (0 - 499 posts)
  
Join Date: Apr 2004
Posts: 16 killmesuicide User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: < 1 sec
Reputation Power: 0
Improve my code, have i missed out any errors?
i spent all day yesterday trying to debug my code and make it xhtml strict, adding touches, have i missed anything?
are there any obvious things wrong with it i can improve?
im not sure about the table layout but if i modify one cell , the whole table seems to scatter

here goes:
_________________________________-

<!DOCTYPE html PUBLIC
"-//W3C//DTD XHTML 1.0 Strict//EN"
"DTD/xhtml1-strict.dtd">

<html>

<head>
</head>

<body bgcolor="000000">


<script language=JavaScript>
<!--

//Disable right mouse click Script
//By Maximus (maximus@nsimail.com) w/ mods by DynamicDrive
//For full source code, visit http://www.dynamicdrive.com

var message="Function Disabled!";

///////////////////////////////////
function clickIE4(){
if (event.button==2){
alert(message);
return false;
}
}

function clickNS4(e){
if (document.layers||document.getElementById&&!document.all){
if (e.which==2||e.which==3){
alert(message);
return false;
}
}
}

if (document.layers){
document.captureEvents(Event.MOUSEDOWN);
document.onmousedown=clickNS4;
}
else if (document.all&&!document.getElementById){
document.onmousedown=clickIE4;
}

document.oncontextmenu=new Function("alert(message);return false")

// -->
</script>





<div align="center">

<table border="0" width="752" cellpadding="0">
<tr>
<td align="left" width="72" height="73" colspan="1" rowspan="2">
<img src="multipfi/sxisym.jpg" width="72" height="73" />
</td>

<td colspan="6" rowspan="2" valign="top"> <img src="multipfi/spherex.jpg" width="287" height="76" /> </td>

<td colspan="6" rowspan="1" align="right"> <a href="main.html"> <img src="multipfi/skyban2.jpg" width="368" height="39" border="0" /> </a> </td>
</tr>

<tr>
<td colspan="6" rowspan="1" align="right">

<FONT color="00FFFF"
size="2"><marquee bgcolor="000000" direction="left" loop="infinite"
width="363"><STRONG> Email us for FREE demo cd: see Audio Area for more details.... (all SkyXI images. music. files. are copyrighted) </STRONG></MARQUEE></FONT> </td>
</tr>

</table>
</div>


<div align="center">

<table border="0" width="752" cellpadding="0">

<tr>
<td colspan="3" rowspan="1" height="65" width="752" align="left"> <img src="multipfi/skyban.jpg" alt="" border="0" width="751" height="63" /> </td>

</tr>


</table>
</div>



<div align="center">

<table border="0" width="752" cellpadding="0">

<tr>

<td>


<table cellpadding="0" border="0">



<tr> <td width="190" height="90" align="left"> <a href="profilep.html"> <img src="multipfi/profileb.jpg" border="0" width="167" height="84" /> </a> </td> <td width="190" height="90" align="left">

<font size="2" color="ffffff"> About us and our services. </br> Info on our productions. </font>

</td> </tr>




<tr> <td width="190" height="90" align="left"> <a href="audioa.html"> <img src="multipfi/audiob.jpg" border="0" width="167" height="84" /> </a> </td> <td width="190" height="90" align="left">

<font size="2" color="ffffff"> Our Audio Area has mp3 </br> downloads, details about </br> our free Demo CD + more... </font>

h</td> </tr>




<tr> <td width="190" height="90" align="left"> <a href="contact.html"> <img src="multipfi/contactb.jpg" border="0" width="167" height="84" /> </a> </td> <td width="190" height="90" align="left">

<font size="2" color="ffffff"> SKyXI Comm: </br> Contact information: </br> Email <br/> Phone <br/> Post <br/> </font>

h</td> </tr>




<tr> <td width="190" height="90" align="left"> <a href="links.html"> <img src="multipfi/linksb.jpg" border="0" width="167" height="84" /> </a> </td> <td width="190" height="90" align="left">

<font size="2" color="ffffff"> Links: </br> Audio production </br> Game development <br/> Programming <br/> </font>

</td> </tr>

</table>


</td>



<td colspan="3" rowspan="1" height="360" width="361">



<table cellpadding="0" border="0">



<tr> <td width="190" height="90" align="left"> <a href="visuala.html"> <img src="multipfi/visualb69.jpg" border="0" width="167" height="88" /> </a> </td> <td width="190" height="90" align="left">

<font size="2" color="DCDCDC"> [ Visual Area Inactive] <br> <i> coming soon: SkyXI AVS presets, animations </br> + more! </i> </font>

</td> </tr>




<tr> <td width="190" height="90" align="left"> <img src="multipfi/xlink.jpg" border="0" width="167" height="84" /> </td> <td width="190" height="90" align="left">



h</td> </tr>



<tr> <td colspan="2" rowspan="2" width ="380" height="190" align="left" valign="middle">

<font size="2" color="40E0D0"> Click appropriate image to proceed.. </br> </br>


To return to this page click the silver banner located at the top right of the page. </br>
</font>
</br>
</br>


<font size="2" color="7CFC00"> Preview tracks avaliable for lisencing at the Audio Area. </br>
</br>

For info on our soundtrack production see our profile + services page... </br>
</font>



</td> </tr>


</table>

</td>


</tr>

</table>
</div>


</body>

</html>
Reply With Quote
  #2  
Old April 29th, 2004, 11:45 AM
Dusk's Avatar
Dusk Dusk is offline
Twilight Thinking
Dev Shed Novice (500 - 999 posts)
  
Join Date: Feb 2003
Location: Oxford UK
Posts: 656 Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level) 
Time spent in forums: 1 Week 5 Days 23 h 2 m 27 sec
Reputation Power: 32
Have you ran it through the XHTML validator?

http://validator.w3.org/
__________________
Cheers,
Dusk

My portfolio
Reply With Quote
  #3  
Old April 29th, 2004, 11:57 AM
Dusk's Avatar
Dusk Dusk is offline
Twilight Thinking
Dev Shed Novice (500 - 999 posts)
  
Join Date: Feb 2003
Location: Oxford UK
Posts: 656 Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level) 
Time spent in forums: 1 Week 5 Days 23 h 2 m 27 sec
Reputation Power: 32
Oops, clicked finish before I had!

Ok, first off:

Using tables for layout is not the best idea, but as you have done, there are other issues:

1/---

<font size="2" color="ffffff"></font> is way out of date, try using css, like:

<style>
p
{
font-size: 10px;
font-weight: normal;
font-family: arial san-serif;
color: #ffffff;
}
</style>


2/---

Marquees, are also out of date, and are not recommended.


3/---

Use correct markup, as in:

<p>blah, blah, blah</p>

and

</br> should be <br />

4/---

All tags should be in lower-case, but as the upper case tags that I can see are font and marquee, it wont matter coz you'll have to remove these if you want it validate

5/---

No-Right-Click scripts are utterly pointless, as there are a dozen ways of getting round this, and they only annoy users and clog up your pages with unnescessary code.


Sorry if this sounds harsh, but if you want it valid XHTML, you're going to have to make all these changes. You should really send it through the validator on the above post, and it'll tell you all the errors...

Hope thats useful
Reply With Quote
  #4  
Old April 30th, 2004, 03:38 AM
jabba_29's Avatar
jabba_29 jabba_29 is offline
Back in HEL
Dev Shed God 8th Plane (8500 - 8999 posts)
  
Join Date: Feb 2002
Location: Finland
Posts: 8,670 jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)jabba_29 User rank is General 10th Grade (Above 100000 Reputation Level)  Folding Points: 57777 Folding Title: Beginner FolderFolding Points: 57777 Folding Title: Beginner FolderFolding Points: 57777 Folding Title: Beginner Folder
Time spent in forums: 3 Months 3 Weeks 4 Days 6 h 4 m 26 sec
Reputation Power: 1618
Send a message via ICQ to jabba_29 Send a message via AIM to jabba_29 Send a message via MSN to jabba_29 Send a message via Yahoo to jabba_29 Send a message via Google Talk to jabba_29 Send a message via Skype to jabba_29
Facebook
Perhaps should have posted in the HTML forums too
__________________
Cheers,

Jamie


# skiFFie | Home of the 'accessibility module' for Drupal
# Jamie Burns [me] Accessibility Module [drupal]
# guidelines | search | wap resources | not getting help | fold to cure

# Any form of employment is strictly prohibited ......


__________________

Let the might of your compassion arise to bring a quick end
to the flowing stream of the blood and tears .....
Please hear my anguished words of truth.
__________________
Reply With Quote
  #5  
Old April 30th, 2004, 05:12 AM
Dusk's Avatar
Dusk Dusk is offline
Twilight Thinking
Dev Shed Novice (500 - 999 posts)
  
Join Date: Feb 2003
Location: Oxford UK
Posts: 656 Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level)Dusk User rank is Sergeant Major (2000 - 5000 Reputation Level) 
Time spent in forums: 1 Week 5 Days 23 h 2 m 27 sec
Reputation Power: 32
Heh heh, they did, but only saw it after I'd replied...
Reply With Quote
Reply

Viewing: Dev Shed Forums > Web Design > Website Critiques > Improve my code, have i missed out any errors?

« Previous Thread | Next Thread »

Thread Tools  Search this Thread 
Search this Thread:

Advanced Search
Display Modes  Rate This Thread 
Linear Mode Linear Mode
Rate This Thread:


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox
Forum Jump


Forums: » Register « |  User CP |  Games |  Calendar |  Members |  FAQs |  Sitemap |  Support | 
  
 





© 2003-2008 by Developer Shed. All rights reserved. DS Cluster 5 hosted by Hostway.