Website Critiques
 
Forums: » Register « |  User CP |  Games |  Calendar |  Members |  FAQs |  Sitemap |  Support | 
User Name:
Password:
Remember me
Go Back   Dev Shed ForumsWeb DesignWebsite Critiques

Reply
Add This Thread To:
  Del.icio.us   Digg   Google   Spurl   Blink   Furl   Simpy   Y! MyWeb 
Thread Tools Search this Thread Rate Thread Display Modes
 
Unread Dev Shed Forums Sponsor:
  #1  
Old January 24th, 2005, 03:32 PM
RoLLiNLoW54's Avatar
RoLLiNLoW54 RoLLiNLoW54 is offline
Contributing User
Dev Shed Newbie (0 - 499 posts)
 
Join Date: Dec 2004
Posts: 219 RoLLiNLoW54 User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: 1 Day 16 h 37 m 6 sec
Reputation Power: 4
www.chitlist.com Contractor Consulting

developed my first member/comment database driven site at www.chitlist.com . comments and critiques greatly appreciated!

i also invite you to join the member section and check out some of the techniques i used for the php/sql etc, this is my first 'commercial' development relying heavily on my code. if you do register but do not intend to use the member section in the future for purposes of the site, sign up as void1, or void2, void3, etc so that i know which users can be deleted. the first 100 members are free, $95/yr after that. if someone wants to view the site to critique after the first 100 users, feel free to contact me

i appreciate any and all comments!

Reply With Quote
  #2  
Old January 24th, 2005, 03:46 PM
Sepodati's Avatar
Sepodati Sepodati is offline
Banned
Dev Shed God 19th Plane (14000 - 14499 posts)
 
Join Date: Dec 1999
Location: Afghanistan
Posts: 14,385 Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)  Folding Points: 72870 Folding Title: Intermediate FolderFolding Points: 72870 Folding Title: Intermediate FolderFolding Points: 72870 Folding Title: Intermediate FolderFolding Points: 72870 Folding Title: Intermediate Folder
Time spent in forums: 2 Months 4 Weeks 20 h 19 m 49 sec
Reputation Power: 1784
Send a message via ICQ to Sepodati Send a message via Yahoo to Sepodati
There are cross site scripting vulnerabilties on your site by not escaping the data before you redisplay it in text boxes. Try logging in with a username of asdf">'><img> for example.

Other that that, the layout seems fine. I didn't have any issues navigating the site. I don't like that you choose the width of the site for me. Size is determined by the user, not the designer.

oh yeah, chitlist sounds like sh*tlist to me.

---John Holmes...

Reply With Quote
  #3  
Old January 24th, 2005, 04:24 PM
Akh's Avatar
Akh Akh is offline
|<.+#f@#+.&.|
Dev Shed Frequenter (2500 - 2999 posts)
 
Join Date: Mar 2002
Location: norway
Posts: 2,688 Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level)Akh User rank is Colonel (50000 - 60000 Reputation Level) 
Time spent in forums: 4 Weeks 7 h 3 m 50 sec
Reputation Power: 600
Text is best as plain text. Using a background image with text is one of the worst possible way to display text,
If the images isn't displayed there is no way for me to get the text. A site should always work whether or not the images is displayed or not.

Secondly your layout breaks totally if one change the font-size,
never try to "force" a set font-size. (A user can always change the font-size)
So I agree with Sep on that point.
__________________

Reply With Quote
  #4  
Old January 24th, 2005, 04:47 PM
RoLLiNLoW54's Avatar
RoLLiNLoW54 RoLLiNLoW54 is offline
Contributing User
Dev Shed Newbie (0 - 499 posts)
 
Join Date: Dec 2004
Posts: 219 RoLLiNLoW54 User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: 1 Day 16 h 37 m 6 sec
Reputation Power: 4
Quote:
Originally Posted by Sepodati
There are cross site scripting vulnerabilties on your site by not escaping the data before you redisplay it in text boxes. Try logging in with a username of asdf">'><img> for example.

Other that that, the layout seems fine. I didn't have any issues navigating the site. I don't like that you choose the width of the site for me. Size is determined by the user, not the designer.

oh yeah, chitlist sounds like sh*tlist to me.

---John Holmes...

both of these replies are exactly what i was looking for. i needed someone other than a typical user to test my site and tell me the vulnerabilities. i appreciate both replies.

with regards to the reply from John Holmes... how would i go about 'escaping the data before i redisplay it in textboxes? i was completely unaware of this vulnerability.

for the site width problem... do you mean setting the site width to a percentage instead of a pixel width?

reply to AKH's reply... what would your suggestion be as to how to duplicate the look i am going for without using an image behind text? table BG color? css? also not sure how i would go about fixing that.

with regards to the fontsize, i am using CSS to determine that, in places, however, i have determined the fontsize in the font tag.

thanks for the replies, keep em comin

also, chitlist was the client's idea... thats what he wanted, so thats what he got

Reply With Quote
  #5  
Old January 24th, 2005, 05:30 PM
Sepodati's Avatar
Sepodati Sepodati is offline
Banned
Dev Shed God 19th Plane (14000 - 14499 posts)
 
Join Date: Dec 1999
Location: Afghanistan
Posts: 14,385 Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)Sepodati User rank is General 12nd Grade (Above 100000 Reputation Level)  Folding Points: 72870 Folding Title: Intermediate FolderFolding Points: 72870 Folding Title: Intermediate FolderFolding Points: 72870 Folding Title: Intermediate FolderFolding Points: 72870 Folding Title: Intermediate Folder
Time spent in forums: 2 Months 4 Weeks 20 h 19 m 49 sec
Reputation Power: 1784
Send a message via ICQ to Sepodati Send a message via Yahoo to Sepodati
wow... I just saw how your whole site is layed over a background image... horrible. You can recreate all of that text using CSS to control the size, color and alignment. There's no need for that image.

As for the vulnerabilties, run the text through htmlentities() before you put it back in the text box.

Assuming $_POST['username'] came from the user and you want to redisplay it back in the text box...
PHP Code:
<?
$safe_username 
htmlentities($_POST['username']);
?>
<input type="text" name="username" value="<?=$safe_username?>" />

---John Holmes...

Reply With Quote
  #6  
Old January 24th, 2005, 06:37 PM
RoLLiNLoW54's Avatar
RoLLiNLoW54 RoLLiNLoW54 is offline
Contributing User
Dev Shed Newbie (0 - 499 posts)
 
Join Date: Dec 2004
Posts: 219 RoLLiNLoW54 User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: 1 Day 16 h 37 m 6 sec
Reputation Power: 4
Quote:
Originally Posted by Sepodati
wow... I just saw how your whole site is layed over a background image... horrible. You can recreate all of that text using CSS to control the size, color and alignment. There's no need for that image.

As for the vulnerabilties, run the text through htmlentities() before you put it back in the text box.

Assuming $_POST['username'] came from the user and you want to redisplay it back in the text box...
PHP Code:
<?
$safe_username 
htmlentities($_POST['username']);
?>
<input type="text" name="username" value="<?=$safe_username?>" />

---John Holmes...
I appreciate your response. i will definitely get to fixing the PHP error as soon as i get back to my room. i'm actually a college student and am in my first web design class as we speak. everything i know ive taught myself and im still learning alot, so i appreciate the help on this site. enormous amount of information here. as far as the CSS goes, i'm unfamiliar to it other than text effects, but this class im in right now focuses on javascript/css so hopefully i will have a better idea. i just did the site the best way i knew how at the time. thanks for your responses though! any other comments and suggestions are also welcome, i know that the design is far far far from perfect.

Reply With Quote
Reply

Viewing: Dev Shed ForumsWeb DesignWebsite Critiques > www.chitlist.com Contractor Consulting


Thread Tools  Search this Thread 
Search this Thread:

Advanced Search
Display Modes  Rate This Thread 
Rate This Thread:


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox
Forum Jump


Forums: » Register « |  User CP |  Games |  Calendar |  Members |  FAQs |  Sitemap |  Support | 
  
 





© 2003-2008 by Developer Shed. All rights reserved. DS Cluster 2 hosted by Hostway
Stay green...Green IT