
September 25th, 2004, 04:50 AM
|
 |
ub0r 7r0|| flam3r
|
|
Join Date: Jul 2004
Location: Near enough to London
Posts: 483
  
Time spent in forums: 17 h 8 m 24 sec
Reputation Power: 7
|
|
Quote: | Originally Posted by CrimsonGT This is the first layout I have put time into. I am working on an online business. Please give me feedback on it and let me know |
In future could you provide a link, I am often too lazy too copy+paste and that I might go and review some other site.
Now looking at your code, I don't know what happend. - First line should be a doctype but instead you've gone strait to your html tag, a common mistake but not a difficult one to avoid.
- You've got both upper case characters and lower case charcters in your markup, all tags should be lower case.
- Table based layout- not something we like here, use css for layout.
- The next html tag... WHAT THE HELL?? why is there another one? then there's even another body tag! Does your page just start again or something?
- Then lower down the page... It does it again!! Whats going on?
- Links to non-existant pages, when a page is unbuilt just link to "#"
- Security... [edit]I wont state the weakness but look at the sticky in the php forums... now... please.[/edit]
|