#1
  1. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Apr 2009
    Location
    ohio
    Posts
    3
    Rep Power
    0

    Question Css help/testing


    #body {

    margin:auto;

    background:#fcfff0;

    color:rgb(16%, 14%, 13%);

    text-align:center;

    width:640px;

    }



    #outer {

    text-align:center;

    border:0px solid #325C74;

    width:640px;

    margin:auto;

    }



    #header {

    height:100px;

    background:#fcfff0;

    color:rgb(16%, 14%, 13%);

    }



    #bar {

    height:25px;

    background:#fcfff0;

    color: rgb(16%, 14%, 13%);

    border:6px solid #325C74;

    text-align:center;

    }



    #cont{

    height:380px;

    width:628px;

    background:#fcfff0;

    color:rgb(16%, 14%, 13%);

    border:6px solid #325C74;

    margin:auto;

    text-align:center;

    }



    #left {

    float: left;
    height:380px;

    width:200px;

    background:#fcfff0;

    color:rgb(16%, 14%, 13%);

    border:0px solid #325C74;

    text-align:center;

    }



    #right {

    float: right;
    height:380px;

    width:200px;

    background:#fcfff0;

    color:rgb(16%, 14%, 13%);

    border:0px solid #325C74;

    text-align:center;

    }



    #footer {

    height:40px;

    width:628px;

    background:#fcfff0;

    color:rgb(55%, 9%, 9%);

    border:6px solid #325C74;

    margin:auto;

    text-align:center;

    }
    my question is there anything I need to do to make it better
    I'm still learning css
    I have tested it at w3 and its passed at all levels but I get 7 warning at css3
  2. #2
  3. Eager to learn
    Devshed Regular (2000 - 2499 posts)

    Join Date
    Jan 2009
    Location
    Maryland, USA
    Posts
    2,230
    Rep Power
    2179
    There's nothing wrong with the code, except on #footer, add clear:both;. I also don't recommend having a fixed height, or width. I much prefer min-width, max-width, and using %'s. Without a link, there's not much else I can say
    "Quality of responses may vary. I reserve the right to change my mind for any reason what-so-ever without admitting I was wrong. I'd prefer to change your mind however, it's easier on my ego". - jwdonahue

    "so no-one has actually bothered to post an original quote ? what's wrong with making up your own?"
    - marnixR
  4. #3
  5. Contributing User
    Devshed Novice (500 - 999 posts)

    Join Date
    Mar 2004
    Location
    Kostolac, Serbia
    Posts
    855
    Rep Power
    1391
    There are two things I would like to comment on your CSS.

    First of all you don't need to specify additional values for your selector's properties if one of them is going to completely cancel the effect of even showing it. Look at the following selector:
    Code:
    border:0px solid #325C74;
    By specifying a value of 0px (xp is btw redundant here) for border width you do not need to specify the border type (solid) and border color (#325C74). This might seem unimportant to some but when you begin to create large CSS files with lots of selectors which contain redundant values you will get files with lot of unnecessary junk in it.

    Also there is nothing wrong with using percentage values in your RGB color specifications but to be honest I never even came close to a CSS rule that was using repcentages to define color values and not be actually a part of a tutorial which was simply explaining that percents can be used to specify color values. Most of the time you will be using hexadecimal values so it might be a good idea for you to start learning the hex system in a way to at least have a feeling which color will be produced with a certain hexadecimal color value combination.

    As for the warnings you get ignore them. The W3 CSS validator is not so perfect after all since it gives you warnings for things that do not exist in your code.
    Last edited by holodoc; April 25th, 2009 at 05:38 PM.
    PHP Code:
    <?php
    abstract class Ignorance extends Stupidity implements Unavoidable 
         public static 
    $humiliation

         private function 
    __construct(){
            
    parent::__destruct();
         }; 

    ?>
  6. #4
  7. No Profile Picture
    Registered User
    Devshed Newbie (0 - 499 posts)

    Join Date
    Apr 2009
    Location
    ohio
    Posts
    3
    Rep Power
    0
    thanks for your advice guys
    you could check my profile for the link to my website since i can't post a links yet
  8. #5
  9. Eager to learn
    Devshed Regular (2000 - 2499 posts)

    Join Date
    Jan 2009
    Location
    Maryland, USA
    Posts
    2,230
    Rep Power
    2179
    So now you want a site critique? Hopefully a moderator could move the thread.

    For those of you who don't want to open up his profile. The link is here:

    http://www.angelfire.com/games3/twrt/

    1. I don't like the width of the site. I don't want to scroll horizontally to reach content. Nor do most users.
    2. Below the ad, that box I thinik should be centered between the top row instead of the center of the screen, unless you choose to center the ads and make them smaller
    3. Style up the navbar a bit. It really is quite plain
    4. "This site is best viewed in Firefox or Safari ". Try making your site work in all browsers

    Comments on this post

    • ChiefWigs1982 disagrees : This could be one of the most hypocritical posts I've ever seen. :/
    "Quality of responses may vary. I reserve the right to change my mind for any reason what-so-ever without admitting I was wrong. I'd prefer to change your mind however, it's easier on my ego". - jwdonahue

    "so no-one has actually bothered to post an original quote ? what's wrong with making up your own?"
    - marnixR

IMN logo majestic logo threadwatch logo seochat tools logo